Reset bruteforce attempt table on successful login#7263
Merged
Conversation
MorrisJobke
requested review from
LukasReschke,
blizzz,
nickvergessen and
rullzer
skjnldsv
approved these changes
Nov 23, 2017
LukasReschke
previously requested changes
Nov 23, 2017
LukasReschke
left a comment
LukasReschke
left a comment
Member
There was a problem hiding this comment.
Tests are failing now. Code looks good otherwise :)
Member
|
Hum, is this related to this pr? |
Member
|
yes |
* only clear the entries that come from the same subnet, same action and same metadata Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
clean-bruteforce-attempt-on-success
branch
from
0d6a08e to
5a270c2
Compare
Codecov Report
@@ Coverage Diff @@
## master #7263 +/- ##
============================================
- Coverage 50.86% 50.85% -0.01%
- Complexity 24550 24553 +3
============================================
Files 1585 1585
Lines 93811 93830 +19
Branches 1354 1354
============================================
+ Hits 47716 47717 +1
- Misses 46095 46113 +18
|
LukasReschke
approved these changes
Nov 24, 2017
Member
|
🐘 |
|
From what I can see here it looks like this is planned for NC13. Will this change be rolled out in NC12 (and maybe other versions) too? |
Member
Author
As of now that backport to 12 is not planned, but maybe we should backport this. @karlitschek @rullzer @blizzz @LukasReschke Opinions on that one? |
Member
|
Should be low risk of breaking things. So I would vote for a backport |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relaxes a lot the situation for people that went into the brute force trap (like in #3058 or #7228)